k2safe/orbit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: harden health probe responses

Browse Source
This commit is contained in:
k2safe
2026-09-20 20:35:34 +08:00
parent 8aef89f179
commit 9e87249ca4
3 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/transport/httpserver/server_test.go
View File

@@ -19,6 +19,14 @@ func TestHealthSeparatesLivenessAndReadiness(t *testing.T) {
if rr.Code != want || strings.Contains(rr.Body.String(), "internal-database-details") {
t.Fatalf("%s: %d %s", path, rr.Code, rr.Body.String())
}
if strings.HasPrefix(path, "/health/") {
if rr.Header().Get("Cache-Control") != "no-store" || rr.Header().Get("X-Content-Type-Options") != "nosniff" {
t.Fatalf("%s: missing anti-cache/security headers: %#v", path, rr.Header())
}
if path == "/health/ready" && rr.Header().Get("Retry-After") != "1" {
t.Fatalf("readiness failure missing retry hint: %#v", rr.Header())
}
}
}
}
@@ -40,6 +48,9 @@ func TestReadinessEntersDrainBeforeShutdown(t *testing.T) {
if draining.Code != http.StatusServiceUnavailable || checks != 1 || strings.Contains(draining.Body.String(), "server is draining") {
t.Fatalf("during drain: status=%d checks=%d body=%s", draining.Code, checks, draining.Body.String())
}
if draining.Header().Get("Retry-After") != "1" || draining.Header().Get("Cache-Control") != "no-store" {
t.Fatalf("draining readiness headers: %#v", draining.Header())
}
}
func TestVersionIsPublicAndBounded(t *testing.T) {