k2safe/orbit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: keep schedulers alive without metrics

Browse Source
This commit is contained in:
k2safe
2026-09-20 17:31:38 +08:00
parent 69a6b79fb0
commit 8d5274f652
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/orbit/main.go
View File

@@ -119,7 +119,9 @@ func run() error {
call, cancel := context.WithTimeout(workflowCtx, 5*time.Second) call, cancel := context.WithTimeout(workflowCtx, 5*time.Second)
_, err := workflows.Tick(call, 100) _, err := workflows.Tick(call, 100)
cancel() cancel()
metrics.RecordBatch("workflow", started, err) if metrics != nil {
metrics.RecordBatch("workflow", started, err)
}
if err != nil && workflowCtx.Err() == nil { if err != nil && workflowCtx.Err() == nil {
slog.Error("workflow batch failed", "node_id", node) slog.Error("workflow batch failed", "node_id", node)
} }
@@ -142,7 +144,9 @@ func run() error {
call, cancel := context.WithTimeout(scheduleCtx, 5*time.Second) call, cancel := context.WithTimeout(scheduleCtx, 5*time.Second)
_, err := schedules.Tick(call, 100) _, err := schedules.Tick(call, 100)
cancel() cancel()
metrics.RecordBatch("schedule", started, err) if metrics != nil {
metrics.RecordBatch("schedule", started, err)
}
if err != nil && scheduleCtx.Err() == nil { if err != nil && scheduleCtx.Err() == nil {
slog.Error("schedule batch failed", "node_id", node) slog.Error("schedule batch failed", "node_id", node)
} }
@@ -170,7 +174,9 @@ func run() error {
call, cancel := context.WithTimeout(recoveryCtx, 5*time.Second) call, cancel := context.WithTimeout(recoveryCtx, 5*time.Second)
_, err := executions.Recover(call, 100) _, err := executions.Recover(call, 100)
cancel() cancel()
metrics.RecordBatch("execution_recovery", started, err) if metrics != nil {
metrics.RecordBatch("execution_recovery", started, err)
}
if err != nil && recoveryCtx.Err() == nil { if err != nil && recoveryCtx.Err() == nil {
slog.Error("execution recovery batch failed", "node_id", node) slog.Error("execution recovery batch failed", "node_id", node)
} }

7
cmd/orbit/metrics_integration_test.go
View File

@@ -135,6 +135,13 @@ func TestIntegrationMetricsProcess(t *testing.T) {
} else if metrics != "" { } else if metrics != "" {
t.Fatal("disabled metrics listener was started") t.Fatal("disabled metrics listener was started")
} }
if !enabled {
select {
case <-done:
t.Fatal("server exited after metrics was disabled")
case <-time.After(2200 * time.Millisecond):
}
}
if err := cmd.Process.Signal(syscall.SIGTERM); err != nil { if err := cmd.Process.Signal(syscall.SIGTERM); err != nil {
t.Fatal(err) t.Fatal(err)
} }