k2safe/orbit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add audited workflow review and bounded task recovery

Browse Source
This commit is contained in:
k2safe
2026-09-18 05:02:47 +08:00
parent 7eac8c365a
commit 1d1a441167
20 changed files with 1437 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
internal/storage/mysql/task_recovery.go
View File

@@ -6,6 +6,7 @@ import (
"encoding/hex"
"encoding/json"
"fmt"
"time"
"git.yuntuo.hk/k2safe/orbit/internal/fault"
core "git.yuntuo.hk/k2safe/orbit/model"
@@ -61,6 +62,11 @@ func allowTaskRecovery(ctx context.Context, tx *sql.Tx, ns, id core.ID, allowSch
} else if ownerID != nil {
return fault.Conflict
}
return taskExecutionSettled(ctx, tx, ns, id)
}
// taskExecutionSettled 仅检查平台内已授权尝试和许可；调用者仍须提供外部执行已结束的证据。
func taskExecutionSettled(ctx context.Context, tx *sql.Tx, ns, id core.ID) error {
var active int
if err := tx.QueryRowContext(ctx, `SELECT COUNT(*) FROM pulse_attempts WHERE namespace_id=? AND task_id=? AND state IN ('LEASED','RUNNING')`, ns, id).Scan(&active); err != nil {
return err
@@ -102,23 +108,7 @@ func (s *TaskStore) ReviewTask(ctx context.Context, t auth.Token, id core.ID, ke
if err != nil {
return err
}
changed, err := tx.ExecContext(ctx, `UPDATE pulse_tasks SET state=?,result=?,effect_uncertain=FALSE,completed_at=?,updated_at=?,revision=revision+1 WHERE namespace_id=? AND id=? AND revision=? AND state='NEEDS_REVIEW'`, in.Outcome, string(in.Result), now, now, t.NamespaceID, id, in.ExpectedRevision)
if err := exactlyOne(changed, err); err != nil {
return err
}
if err := releaseQueueTask(ctx, tx, t.NamespaceID, v.QueueID); err != nil {
return err
}
out.Task, err = readTask(ctx, tx, t.NamespaceID, id, false)
if err != nil {
return err
}
digest, err := requestDigest(in.Result)
if err != nil {
return err
}
after := map[string]any{"state": in.Outcome, "revision": fmt.Sprint(out.Task.Revision), "effect_uncertain": false, "execution_settled": true, "result_digest": hex.EncodeToString(digest[:])}
out.AuditID, err = appendAuditWithEvidence(ctx, tx, t, identity, id, "task", "task.review", in.Reason, in.EvidenceRef, map[string]any{"state": v.State, "revision": fmt.Sprint(v.Revision), "effect_uncertain": v.EffectUncertain}, after)
out, err = applyTaskReview(ctx, tx, t, task, identity, in, now)
if err != nil {
return err
}
@@ -183,3 +173,33 @@ func (s *TaskStore) RetryTask(ctx context.Context, t auth.Token, id core.ID, key
})
return out, err
}
// applyTaskReview 核查状态、额度与任务审计同事务。调用方已校验归属并持锁，须在最后发布结果事件。
func applyTaskReview(ctx context.Context, tx *sql.Tx, t auth.Token, task executionTask, identity core.ID, in service.ReviewInput, now time.Time) (service.ReviewResult, error) {
var out service.ReviewResult
v := task.view
if v.State != pulse.TaskNeedsReview || v.Revision != in.ExpectedRevision || task.lease != nil {
return out, fault.Conflict
}
changed, err := tx.ExecContext(ctx, `UPDATE pulse_tasks SET state=?,result=?,effect_uncertain=FALSE,completed_at=?,updated_at=?,revision=revision+1 WHERE namespace_id=? AND id=? AND revision=? AND state='NEEDS_REVIEW'`, in.Outcome, string(in.Result), now, now, t.NamespaceID, v.ID, in.ExpectedRevision)
if err := exactlyOne(changed, err); err != nil {
return out, err
}
if err := releaseQueueTask(ctx, tx, t.NamespaceID, v.QueueID); err != nil {
return out, err
}
out.Task, err = readTask(ctx, tx, t.NamespaceID, v.ID, false)
if err != nil {
return out, err
}
digest, err := requestDigest(in.Result)
if err != nil {
return out, err
}
after := map[string]any{"state": in.Outcome, "revision": fmt.Sprint(out.Task.Revision), "effect_uncertain": false, "execution_settled": true, "result_digest": hex.EncodeToString(digest[:])}
out.AuditID, err = appendAuditWithEvidence(ctx, tx, t, identity, v.ID, "task", "task.review", in.Reason, in.EvidenceRef, map[string]any{"state": v.State, "revision": fmt.Sprint(v.Revision), "effect_uncertain": v.EffectUncertain}, after)
if err != nil {
return out, err
}
return out, nil
}